RE: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,
Thanks for the review.

> -----Original Message-----
> From: geert.uytterhoeven@xxxxxxxxx [mailto:geert.uytterhoeven@xxxxxxxxx]
> On Behalf Of Geert Uytterhoeven
> Sent: 10 July 2017 08:55
> To: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland
> <mark.rutland@xxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; Sergei
> Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>; Simon Horman
> <horms@xxxxxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; Chris
> Paterson <Chris.Paterson2@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; Linux-
> Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
>
> Hi Biju,
>
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Reviewed-by: Chris Paterson <chris.paterson2@xxxxxxxxxxx>
>
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> >                         #size-cells = <0>;
> >                         status = "disabled";
> >                 };
> > +
> > +               avb: ethernet@e6800000 {
> > +                       compatible = "renesas,etheravb-r8a7743",
> > +                                    "renesas,etheravb-rcar-gen2";
> > +                       reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > +                       interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
>

OK. I will fix this.
> s/0/GIC_SPI/
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux