On 06/19/2017 01:16 PM, Laurent Pinchart wrote:
Hi Hans,
On Thursday 15 Jun 2017 10:53:33 Hans Verkuil wrote:
On 06/15/17 10:24, Laurent Pinchart wrote:
The WPF vertical flip is only supported on Gen3 SoCs on the VSP2-I.
Don't enable it on other VSP2 instances.
Signed-off-by: Laurent Pinchart
<laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
Should this go to older kernels as well? Or is that not needed?
Now that I have access to the hardware again, after further testing, it looks
like vertical flip is implemented in the VSP2-B[CD] and VSP2-D even though the
datasheet states otherwise. Let's ignore this patch for now, I'll try to
double-check with Renesas.
Patches 2-6 are OK, though? If they are, then I'll pick them up.
I've delegated this patch to you, just 'undelegate' it or reject it once you know
what should be done with this patch.
Regards,
Hans
---
drivers/media/platform/vsp1/vsp1_drv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_drv.c
b/drivers/media/platform/vsp1/vsp1_drv.c index 048446af5ae7..239996cf882e
100644
--- a/drivers/media/platform/vsp1/vsp1_drv.c
+++ b/drivers/media/platform/vsp1/vsp1_drv.c
@@ -690,7 +690,7 @@ static const struct vsp1_device_info
vsp1_device_infos[] = {
.version = VI6_IP_VERSION_MODEL_VSPBD_GEN3,
.model = "VSP2-BD",
.gen = 3,
- .features = VSP1_HAS_BRU | VSP1_HAS_WPF_VFLIP,
+ .features = VSP1_HAS_BRU,
.rpf_count = 5,
.wpf_count = 1,
.num_bru_inputs = 5,
@@ -700,7 +700,7 @@ static const struct vsp1_device_info
vsp1_device_infos[] = {
.model = "VSP2-BC",
.gen = 3,
.features = VSP1_HAS_BRU | VSP1_HAS_CLU | VSP1_HAS_HGO
- | VSP1_HAS_LUT | VSP1_HAS_WPF_VFLIP,
+ | VSP1_HAS_LUT,
.rpf_count = 5,
.wpf_count = 1,
.num_bru_inputs = 5,
@@ -709,7 +709,7 @@ static const struct vsp1_device_info
vsp1_device_infos[] = {
.version = VI6_IP_VERSION_MODEL_VSPD_GEN3,
.model = "VSP2-D",
.gen = 3,
- .features = VSP1_HAS_BRU | VSP1_HAS_LIF | VSP1_HAS_WPF_VFLIP,
+ .features = VSP1_HAS_BRU | VSP1_HAS_LIF,
.rpf_count = 5,
.wpf_count = 2,
.num_bru_inputs = 5,
