Hi Biju, On Fri, Jun 16, 2017 at 4:57 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > Adding pinctrl support for scif0 interface. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> The patch looks good to me, but without schematics, we cannot verify the actual pins used. Are the schematics somewhere available? Having access to them would allow us doing a better job reviewing your DTS patches. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds