Re: [PATCH/RFC 4/5] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 16, 2017 at 09:21:04AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Jun 16, 2017 at 9:12 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Fri, Jun 09, 2017 at 09:39:49AM +0200, Geert Uytterhoeven wrote:
> >> On Thu, Jun 8, 2017 at 3:13 PM, Simon Horman <horms+renesas@xxxxxxxxxxxx> wrote:
> >> > R-Car Gen3 has a dedicated DMA controller for SDHI module. Since
> >> > the DMAC is in a part of SDHI module and is not suitable as dmaengine,
> 
> >> > --- a/drivers/mmc/host/Kconfig
> >> > +++ b/drivers/mmc/host/Kconfig
> 
> >> > +config MMC_SDHI_SYS_DMAC
> >> > +       tristate "DMA support use of SYS DMAC with SDHI SD/SDIO controller"
> >>
> >> DMA support for SYS_DMAC?
> >
> > How about this?
> >
> > config MMC_SDHI_SYS_DMAC
> >         tristate "DMA for SDHI SD/SDIO controllers using SYS-DMAC"
> 
> Better!
> 
> >         ...
> >         help
> >            This provides DMA support for the SDHI SD/SDIO controllers
> >            using SYS-DMAC via DMA Engine. This supports the controllers
> 
> I would drop "the".

Will do, thanks.

> >            found in SuperH and Renesas ARM based SoCs.
> >
> > config MMC_SDHI_INTERNAL_DMAC
> >         tristate "DMA for SDHI SD/SDIO controllers using on-chip bus mastering"
> >         ...
> >         help
> >            This provides DMA support for the SDHI SD/SDIO controllers
> >            using on-chip bus mastering. This supports the controllers
> 
> Likewise.
> 
> >            found in arm64 based SoCs.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux