Hi Biju, On Fri, Jun 2, 2017 at 6:22 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > Add support for iWave RZG1M Qseven System On Module. > http://www.iwavesystems.com/rz-g1m-qseven-module.html Thanks for your patch! > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > Reviewed-by: Chris Paterson <chris.paterson2@xxxxxxxxxxx> > --- /dev/null > +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > @@ -0,0 +1,27 @@ > +/* > + * Device Tree Source for the iWave-RZG1M-20M Qseven SOM > + * > + * Copyright (C) 2017 Renesas Electronics Corp. > + * > + * This file is licensed under the terms of the GNU General Public License > + * version 2. This program is licensed "as is" without any warranty of any > + * kind, whether express or implied. > + */ > + > +#include "r8a7743.dtsi" > + > +/ { Given this is a sub-board with many other components, I think it should have its own (documented) compatible value, e.g. compatible = "iwave,g20m", "renesas,r8a7743"; > + memory@40000000 { > + device_type = "memory"; > + reg = <0 0x40000000 0 0x20000000>; > + }; > + > + memory@200000000 { > + device_type = "memory"; > + reg = <2 0x00000000 0 0x20000000>; > + }; > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds