Re: [PATCH v3 1/2] device property: Add fwnode_graph_get_port_parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

On 23/05/17 22:37, Sakari Ailus wrote:
> Hi Kieran,
> 
> On Tue, May 23, 2017 at 06:15:42PM +0100, Kieran Bingham wrote:
>>
>>
>> On 23/05/17 13:58, Sakari Ailus wrote:
>>> Hi Kieran,
>>>
>>> On Mon, May 22, 2017 at 06:36:37PM +0100, Kieran Bingham wrote:
>>>> From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>>>>
>>>> Provide a helper to obtain the parent device fwnode without first
>>>> parsing the remote-endpoint as per fwnode_graph_get_remote_port_parent.
>>>>
>>>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>>>>
>>>> ---
>>>> v2:
>>>>  - Rebase on top of Sakari's acpi-graph-clean branch and simplify
>>>>
>>>> v3:
>>>>  - Fix up kerneldoc
>>>>  - Get the 'port' of the endpoint to find the parent of the port
>>>>
>>>>  drivers/base/property.c  | 15 +++++++++++++++
>>>>  include/linux/property.h |  2 ++
>>>>  2 files changed, 17 insertions(+)
>>>>
>>>> diff --git a/drivers/base/property.c b/drivers/base/property.c
>>>> index b311a6fa7d0c..fdbc644fd743 100644
>>>> --- a/drivers/base/property.c
>>>> +++ b/drivers/base/property.c
>>>> @@ -1169,6 +1169,21 @@ fwnode_graph_get_next_endpoint(struct fwnode_handle *fwnode,
>>>>  EXPORT_SYMBOL_GPL(fwnode_graph_get_next_endpoint);
>>>>  
>>>>  /**
>>>> + * fwnode_graph_get_port_parent - Return the device fwnode of a port endpoint
>>>> + * @endpoint: Endpoint firmware node of the port
>>>> + *
>>>> + * Return: the firmware node of the device the @endpoint belongs to.
>>>> + */
>>>> +struct fwnode_handle *
>>>> +fwnode_graph_get_port_parent(struct fwnode_handle *endpoint)
>>>> +{
>>>> +	struct fwnode_handle *port = fwnode_get_next_parent(endpoint);
>>>> +
>>>> +	return fwnode_call_ptr_op(port, graph_get_port_parent);
>>>
>>> I missed one thing: the reference to port obtained in
>>> fwnode_get_next_parent() needs to be released.
>>>
>>> I can do the change while applying the patch on top of the set if you're ok
>>> with that.
>>
>> Yes, that would be great thanks.
> 
> Thanks! The patch actually came out in this form:
> 
> <URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=acpi-graph-cleaned&id=6c9e58006e73de03441337f3ca6247afed28cf0a>
> 
> I'll post it to list once I've rebased the set again, I hope you're ok with
> that. :-)

That looks great.

Thanks
--
Kieran



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux