Hi Ulrich, On Fri, May 19, 2017 at 3:07 PM, Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> wrote: > Add SCIF1 pin groups to the R8A7792 PFC driver. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> Thanks for your patch! > These are the pins the MAX9260 deserializers are connected to on Blanche. Only RX and TX are connected, not SCK ;-) > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7792.c > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7792.c > @@ -1137,6 +1137,21 @@ static const unsigned int scif0_ctrl_pins[] = { > static const unsigned int scif0_ctrl_mux[] = { > RTS0_N_MARK, CTS0_N_MARK, > }; > +/* - SCIF1 ------------------------------------------------------------------ */ > +static const unsigned int scif1_data_pins[] = { > + /* RX, TX */ > + RCAR_GP_PIN(10, 19), RCAR_GP_PIN(10, 18), > +}; > +static const unsigned int scif1_data_mux[] = { > + RX1_MARK, TX1_MARK, > +}; > +static const unsigned int scif1_clk_pins[] = { > + /* SCK */ > + RCAR_GP_PIN(10, 15), > +}; > +static const unsigned int scif1_clk_mux[] = { > + SCK1_MARK, > +}; Can you please add scif1_ctrl_pins, too? BTW, do you mind adding SCIF2? Then we have all SCIF instances covered. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds