Hi Shimoda-san, On Thu, May 18, 2017 at 1:13 PM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: >> >> +- reg: offset and length of the partial USB 3.0 Host PHY register block. >> >> +- #phy-cells: see phy-bindings.txt in the same directory, must be <0>. >> > >> > I think we should add "clocks" property as required. >> > >> >> +Optional properties: >> > >> > You should add "renesas,use-on-chip-clk" here. >> > And, the name of "use-on-chip-clk" is not good to me. >> > FYI, my developing patch names "renesas,usb-extal". >> >> Can this be decided at runtime, e.g. by looking at the rates of the clocks >> to see which one is available/best suited? > > According to the HW manual, this module cannot see which one is available/best suited. > So, I don't think this can be decided at runtime. I mean, can't Linux look at the rates of the two clocks, and if one is zero, use the other? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds