Re: ASoC: rsnd: fix sound route path when using SRC6/SRC9

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert

> > Hmm....
> > I tried random code/compile, but gcc behavior seems strange.
> > Fore example if I removed next line, this warning disappeard
> >
> > -               data = path[rsnd_mod_id(src)] |
> > -                       cmd_case[rsnd_mod_id(src)] << 16;
> > +               data = path[rsnd_mod_id(src)];
> >
> > Is this related to this ?
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59124
> 
> Perhaps.
> 
> I guess the main question is: can src be NULL here?
> If yes, rsnd_mod_id(src) will be -1.

No. cmd itself will not be used if src was NULL on this HW.
But, yes, it seems gcc is checking -1 value here.
It is OK, but why it warns only here ??

Best regards
---
Kuninori Morimoto



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux