Hi Kieran, On Thu, May 11, 2017 at 7:21 PM, Kieran Bingham <kbingham@xxxxxxxxxx> wrote: > From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > Provide bindings between the VIN, CSI and the ADV7482 on the r8a7795. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > index 7a8986edcdc0..e295f041b36a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts I think this should be added to salvator-x.dtsi instead. > @@ -387,6 +403,68 @@ > }; > }; > > +&i2c4 { > + status = "okay"; Please extend the existing "&i2c4 { ... }" section. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds