Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:43 Niklas Söderlund wrote: > Use rvin_reset_format() in rvin_s_dv_timings() instead of just resetting > a few fields. This fixes an issue where the field format was not > properly set after S_DV_TIMINGS. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c > b/drivers/media/platform/rcar-vin/rcar-v4l2.c index > 69bc4cfea6a8aeb5..7ca27599b9982ffc 100644 > --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > @@ -573,12 +573,8 @@ static int rvin_s_dv_timings(struct file *file, void > *priv_fh, if (ret) > return ret; > > - vin->source.width = timings->bt.width; > - vin->source.height = timings->bt.height; > - vin->format.width = timings->bt.width; > - vin->format.height = timings->bt.height; > - > - return 0; > + /* Changing the timings will change the width/height */ > + return rvin_reset_format(vin); vin->source won't be updated anymore. Is this intentional ? > } > > static int rvin_g_dv_timings(struct file *file, void *priv_fh, -- Regards, Laurent Pinchart
