On Wed, Apr 26, 2017 at 2:21 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Wed, Apr 5, 2017 at 4:07 PM, Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote: >> Add combined gpio and pin controller driver for Renesas RZ/A1 >> r7s72100 SoC. >> >> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > >> --- /dev/null >> +++ b/drivers/pinctrl/pinctrl-rza1.c > >> +/* >> + * Keep this up-to-date with pinconf-generic.h: it performs packing of >> + * pin conf flags and argument during pinconf_generic_parse_dt_config(); >> + * we simply discard pinconf argument here >> + */ >> +#define PIN_CONF_UNPACK(pinconf) ((pinconf) & 0xffUL) > > Perhaps this should be moved to pinconf-generic.h, to make sure it stays > up-to-date? I agree. Use the generic macros. If further processing is needed, make a static inline to discard config flags etc. Yours, Linus Walleij
