Re: Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram
From: Michal Hocko <mhocko@xxxxxxxxxx>
Date: Wed, 19 Apr 2017 09:10:39 +0200
Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Linux MM <linux-mm@xxxxxxxxx>, Linux PM list <linux-pm@xxxxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Linux-Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>
In-reply-to: <201704190541.v3J5fUE3054131@www262.sakura.ne.jp>
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed 19-04-17 14:41:30, Tetsuo Handa wrote:
[...]
> Somebody is waiting forever with cpu_hotplug.lock held?

Why would that matter for drain_all_pages? It doesn't use
get_online_cpus since a459eeb7b852 ("mm, page_alloc: do not depend on
cpu hotplug locks inside the allocator") while ce612879ddc7 ("mm: move
pcp and lru-pcp draining into single wq") was merged later.

-- 
Michal Hocko
SUSE Labs

Follow-Ups:
- Re: Re: Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram
  - From: Tetsuo Handa

References:
- "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram
  - From: Geert Uytterhoeven
- Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram
  - From: Michal Hocko
- Re: Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram
  - From: Tetsuo Handa

Prev by Date: Re: [PATCH] i2c: rcar: fix resume by always initializing registers before transfer
Next by Date: Re: Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram
Previous by thread: Re: Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram
Next by thread: Re: Re: Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]