On 04/17/2017 11:19 AM, Sergei Shtylyov wrote:
> Hello!
Hi!
> On 4/16/2017 7:57 PM, Marek Vasut wrote:
>
>> Add bindings for the GyroADC block and it's associated clock.
>
> Well, I already spoke to you about the bindings on IRC...
That's fixed.
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
>> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
>> ---
>> arch/arm/boot/dts/r8a7791.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/r8a7791.dtsi
>> b/arch/arm/boot/dts/r8a7791.dtsi
>> index 4d0c2ce59900..1b099dbc9eef 100644
>> --- a/arch/arm/boot/dts/r8a7791.dtsi
>> +++ b/arch/arm/boot/dts/r8a7791.dtsi
>> @@ -776,6 +776,15 @@
>> status = "disabled";
>> };
>>
>> + adc: adc@e6e54000 {
>
> Why not label it "gyroadc:"?
We can ... I don't mind either way. Shall we ?
>> + compatible = "renesas,r8a7791-gyroadc", "renesas,rcar-gyroadc";
>> + reg = <0 0xe6e54000 0 64>;
>
> s/64/0x40/.
The surrounding code uses 64, so I kept it consistent.
> [...]
>> @@ -1133,6 +1142,13 @@
>> clock-frequency = <0>;
>> };
>>
>> + /* GyroADC clock */
>> + adc_clk: adc_clk {
>
> We geberally skip the "_clk" suffix in the clock node names, so that
> the clock name generated from the node name doesn't have this suffix.
Fixed
> [...]
>
> MBR, Sergei
>
--
Best regards,
Marek Vasut
