Re: [PATCH v3] phy: rcar-gen3-usb2: fix implementation for runtime PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tuesday 04 April 2017 05:06 PM, Yoshihiro Shimoda wrote:
> Hi Kishon,
> 
>> From: Yoshihiro Shimoda, Sent: Tuesday, March 14, 2017 8:38 AM
>>
>> This patch fixes an issue that this driver doesn't take care of the runtime
>> PM. This code assumed that devm_phy_create() called pm_runtime_enable(dev),
>> but it misunderstood the dev_phy_create()'s specification.
>> This driver should call its own pm_runtime_enable() before dev_phy_create().
>>
>> Fixes: f3b5a8d9b50d ("phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver")
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>> ---
>>  Changes from v2:
>>   - revise the commit log (s/pm_runtime_pm/pm_runtime_enable)
>>
>>  Changes from v1:
>>   - revise the commit log (s/the own/its own/)
>>   - simplify return code in probe().
> 
> I'm afraid but would you review this patch?

sure, the patch looks good.

merged now, thanks.

-Kishon



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux