On Sun, Mar 19, 2017 at 03:02:48PM +0100, Geert Uytterhoeven wrote: Hi Geert, > Thanks for your patch! > But next time, please send it inline, for easier commenting. Thanks! Will do that next time. > From a code maintenance point of view, I think it's safer to update the info > pointer itself, cfr. "[PATCH v2 1/4] pinctrl: sh-pfc: Update info pointer > after SoC-specific init" > (https://www.spinics.net/lists/linux-renesas-soc/msg12375.html). Agree! It's good that printing the correct PFC driver name is already fixed on your side. Best regards, Eugeniu.