Re: [PATCH 1/5] rtc: rtc-sh: add support for rza series

[Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>]

Mostly good, one nitpick:

On 16/03/2017 at 13:51:08 -0400, Chris Brandt wrote:
>  	res = platform_get_resource(pdev, IORESOURCE_IO, 0);
> +	if (res == NULL)

if (!res) is preferred here

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com