Hi Chris, On Fri, Mar 17, 2017 at 2:41 PM, Chris Brandt <Chris.Brandt@xxxxxxxxxxx> wrote: > On Friday, March 17, 2017, Geert Uytterhoeven wrote: >> > On Friday, March 17, 2017, Geert Uytterhoeven wrote: >> >> On Thu, Mar 16, 2017 at 6:51 PM, Chris Brandt >> >> <chris.brandt@xxxxxxxxxxx> >> >> wrote: >> >> > +- clocks: the clock source for the RTC controller. >> >> >> >> The datasheet mentions 3 possible clock sources? >> > >> > There is the clock source that does the counting (RTC_X1, RTC_X3, XTAL), >> and then a clock source that runs the register interface (run off of the >> p0 clock). So I just need to turn on the p0 clock so I can get at the >> registers. Note that if you do a hard reset with a RESET button, and all >> the registers in the chip go back to their POR state, the counter still >> counts off of the 32KHz XTAL even though the "peripheral clock" is stopped >> (which just means you can't get to the registers). >> > >> > In reality, you have to assume the RTC counting source has already been >> set up by u-boot, or from a past reboot, so I don't do any of that select >> configuration at all. >> >> it would still be good to have phandles to the external clock sources as >> well, as that describes the hardware topology. > > I'm confused, you mean make new clocks node for RTC_X1 (fixed at 32.768kHZ) and > RTC_X3 (fixed at 4MHz), but then not really do anything with then? (the driver You still do something with them, as they'll be linked from the rtc device node. > doesn't need them) The driver may use them in the future. E.g. to select among X1, X3, or EXTAL, depending on availability. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds