Re: [PATCH/RFC 1/2] usb: host: ehci-platform: set hcd->phy to avoid phy_get() in usb_add_hcd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 10 Mar 2017, Yoshihiro Shimoda wrote:

> This patch sets hcd->phy from own phy context to avoid phy_get()
> in usb_add_hcd(). Since hcd.c manage the phy only in usb_add_hcd()
> and usb_remove_hcd(), there is difficult to manage the phy in
> suspend/resume.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> ---
>  drivers/usb/host/ehci-platform.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
> index a268d9e..4ae27e9 100644
> --- a/drivers/usb/host/ehci-platform.c
> +++ b/drivers/usb/host/ehci-platform.c
> @@ -222,6 +222,8 @@ static int ehci_platform_probe(struct platform_device *dev)
>  					goto err_put_hcd;
>  			}
>  		}
> +		/* Avoiding phy_get in usb_add_hcd() */
> +		hcd->phy = priv->phys[0];

This won't work if priv->num_phys == 0 (in that case, priv->phys 
doesn't get allocated).

Apart from this I have no objection, but other people may.

Alan Stern




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux