Hi Robin, On Wed, Mar 8, 2017 at 9:34 PM, Robin Murphy <robin.murphy@xxxxxxx> wrote: > On 08/03/17 11:02, Magnus Damm wrote: >> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> >> >> Write IMCTR both in the root device and the leaf node. >> >> Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> >> --- >> >> Changes since V2: >> - None >> >> Changes since V1: >> - None >> >> drivers/iommu/ipmmu-vmsa.c | 17 ++++++++++++++--- >> 1 file changed, 14 insertions(+), 3 deletions(-) >> >> --- 0018/drivers/iommu/ipmmu-vmsa.c >> +++ work/drivers/iommu/ipmmu-vmsa.c 2017-03-08 18:30:36.870607110 +0900 >> @@ -286,6 +286,16 @@ static void ipmmu_ctx_write(struct ipmmu >> ipmmu_write(domain->root, domain->context_id * IM_CTX_SIZE + reg, data); >> } >> >> +static void ipmmu_ctx_write2(struct ipmmu_vmsa_domain *domain, unsigned int reg, >> + u32 data) > > That's pretty cryptic. Maybe both functions could do with less ambiguous > names - something like ipmmu_ctx_write_root() vs. ipmmu_ctx_write_all(), > perhaps? (and if there's a more specific hardware term than "all" that > describes this kind of configuration, even better). Yeah I agree. Will fix in next version! Thanks, / magnus
