Hi Magnus, On Wed, Mar 8, 2017 at 12:02 PM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote: > From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> > > Hook up IOMMU_OF_DECLARE() support in case CONFIG_IOMMU_DMA > is enabled. The only current supported case for 32-bit ARM > is disabled, however for 64-bit ARM usage of OF is required. > > Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx While I'm not such a big fan of *_OF_DECLARE() (it doesn't support deferred probing, which is needed for any device with dependencies, like clocks and power domains), what's the rationale for not using IOMMU_OF_DECLARE() on arm32, and thus the need for setup_done? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds