On Mon, Mar 6, 2017 at 9:03 PM, Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > The .thermal_init needs to be delayed a short amount of to allow for the of ... (thx Sergei ;-) > TEMP register to contain something useful. If it's not delayed theses these > warnings are common during boot: > > thermal thermal_zone0: failed to read out thermal zone (-5) > thermal thermal_zone1: failed to read out thermal zone (-5) > thermal thermal_zone2: failed to read out thermal zone (-5) > > The warnings are triggered by the first call to .get_temp while the TEMP .get_temp() > register contains 0 and rcar_gen3_thermal_get_temp() returns -EIO since > a TEMP value of 0 will result in a temperature reading which is out of > specifications. > > This should have been done in the initial commit which adds the driver > as the same issue was found and corrected for r8a7795. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds