RE: [PATCH v5 1/3] watchdog: add rza_wdt driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday, March 04, 2017, Guenter Roeck wrote:
> > +#include <linux/platform_device.h>
> > +#include <linux/module.h>
> > +#include <linux/of_address.h>
> > +#include <linux/delay.h>
> > +#include <linux/watchdog.h>
> > +#include <linux/clk.h>
> > +
> 
> Also needs to include <linux/bitops.h>. While at it, please order include
> files alphabetically.

OK.

> > +	platform_set_drvdata(pdev, priv);
> 
> This is now unnecessary.

OK.


Thank you,
Chris





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux