Hi Chris,
On Thu, Mar 2, 2017 at 4:38 PM, Chris Brandt <Chris.Brandt@xxxxxxxxxxx> wrote:
>> > + /*
>> > + * Since the max possible timeout of our 8-bit count register is
>> less
>> > + * than a second, we must use max_hw_heartbeat_ms.
>> > + */
>> > + priv->wdev.max_hw_heartbeat_ms = (1000 * U8_MAX)/rate;
>>
>> space before and after /
>
> OK.
> #Funny because checkpatch.pl said it didn't like a space on one side but
> not the other, so I choose no spaces and it was happy. I'm way below 80
> characters for that line so it doesn't matter to me.
Just drop the parentheses? Standard C operator precedence is fine here.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
