Hi Mark,
On Fri, Feb 17, 2017 at 7:07 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote:
> On Fri, Feb 17, 2017 at 04:04:09PM +0100, Geert Uytterhoeven wrote:
>> From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
>>
>> This patch adds Cortex-A53 CPU cores to r8a7795 SoC for a total of 8
>> cores (4 x Cortex-A57 + 4 x Cortex-A53).
>
>> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
>> <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
>> <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
>> - <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
>> + <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
>> interrupt-affinity = <&a57_0>,
>> <&a57_1>,
>> <&a57_2>,
>> - <&a57_3>;
>> + <&a57_3>,
>> + <&a53_0>,
>> + <&a53_1>,
>> + <&a53_2>,
>> + <&a53_3>;
>> };
>
> This isn't quite right; the A53 cores should have a separate PMU node.
>
> The PMU hardware is different across microarchitectures, and they must
> be handled separately.
Oops, the original patch predated the evolution of "arm,armv8-pmuv3" into
separate "arm,cortex-a57-pmu" and "arm,cortex-a53-pmu".
Will fix...
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
