Hi Geert,
On 20/02/17 20:45, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Mon, Feb 20, 2017 at 6:47 PM, Kieran Bingham
> <kieran.bingham@xxxxxxxxxxxxxxxx> wrote:
>> This change breaks POSIX SH compliance, as reported by shellcheck:
>>
>> In scripts/bin2png.sh line 7:
>> local pnm=${file/%bin/pnm}
>> ^-- SC2039: In POSIX sh, string replacement is not supported.
>>
>>
>> In scripts/bin2png.sh line 8:
>> local png=${file/%bin/png}
>> ^-- SC2039: In POSIX sh, string replacement is not supported.
>>
>> It also breaks on my system which uses a strict posix compliant shell :D
>
> Does "local pnm=${file%bin}pnm" work?
Yes, it does indeed seem to work so far!
Thanks for the hint.
I'll test a bit more and hopefully send a patch tomorrow :D
--
Kieran
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
