Hi Sudeep, On Fri, Feb 17, 2017 at 6:51 PM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > On 17/02/17 15:30, Geert Uytterhoeven wrote: >> Add a device node for the Cortex-A53 L2 cache-controller. >> >> The L2 cache for the Cortex-A53 CPU cores is 512 KiB large (organized as >> 32 KiB x 16 ways). >> >> Extracted from a patch by Takeshi Kihara in the BSP. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> --- >> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi >> index 6c0a65abf9fd09eb..d848e94d7282e5aa 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi >> @@ -62,6 +62,14 @@ >> cache-unified; >> cache-level = <2>; >> }; >> + >> + L2_CA53: cache-controller@100 { >> + compatible = "cache"; >> + reg = <0x100>; > > Is this not integrated L2 cache ? IIUC reg is MPIDR of the cpu and > representing it as cache controller with some reg value doesn't sound > correct IMO. So this should be cache-controller-1, without a reg property? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds