Hi Geert,
Thank you for your review!
Chris
On Tuesday, February 14, 2017, Geert Uytterhoeven wrote:
> On Mon, Feb 13, 2017 at 7:25 PM, Chris Brandt <chris.brandt@xxxxxxxxxxx>
> wrote:
> > Add device tree bindings document for renesas-reset driver.
> > This driver uses the WDT hardware to issue an immediate reset.
> >
> > Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/power/reset/renesas-reset.txt | 15
> +++++++++++++++
> > 1 file changed, 15 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/power/reset/renesas-reset.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/power/reset/renesas-reset.txt
> > b/Documentation/devicetree/bindings/power/reset/renesas-reset.txt
> > new file mode 100644
> > index 0000000..241722d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/renesas-reset.txt
> > @@ -0,0 +1,15 @@
> > +Device-Tree bindings for Renesas WDT reset functionality
>
> Please drop "reset", as this is a watchdog device.
>
> > +Required properties:
> > + - compatible: must be one or more of the following:
> > + - "renesas,r7s72100-reset" for the r7s72100 SoC
> > + - "renesas,wdt-reset"
> > + This is a fallback for the above renesas,*-reset
> > +entries
>
> Please use "renesas,r7s72100-wdt". DT describes the hardware (watchdog),
> not the software policy (use it for reset only, as a max. timeout of 125
> ms is too short for a usable watchdog).
>
> > + - reg: base address and length of the WDT register block
> > +
> > +Example node:
> > + wdt: timer@fcfe0000 {
> > + compatible = "renesas,r7s72100-reset", "renesas,wdt-
> reset";
> > + reg = <0xfcfe0000 0x6>;
> > + };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
