Hi Kieran,
Thank you for the patch.
On Thursday 01 Dec 2016 21:31:45 Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
>
> Provide a utility script to execute all vsp unit tests, as well
> as the option to execute multiple iterations of the suite.
>
> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
>
> ---
> v2
> - remove spurious uses of ';'
> - fix output logging
>
> scripts/vsp-tests.sh | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100755 scripts/vsp-tests.sh
>
> diff --git a/scripts/vsp-tests.sh b/scripts/vsp-tests.sh
> new file mode 100755
> index 000000000000..8b21176ccc09
> --- /dev/null
> +++ b/scripts/vsp-tests.sh
> @@ -0,0 +1,49 @@
> +#!/bin/sh
> +
> +##
> +## VSP Tests runner
> +##
> +## Automatically execute all vsp-unit tests
> +## Move test failure results to a specific folder for
> +## the running kernel version
> +##
> +## An argument can be provided to specify the number of
> +## iterations to perform
> +##
> +## usage:
> +## ./vsp-tests.sh <n>
> +##
> +## n: Number of iterations to execute test suite
> +##
> +
> +KERNEL_VERSION=`uname -r`
> +
> +run_test() {
> + echo $1
I would print "- $1" to make the output easier to read.
> + ./$1
> +
> + if [ $(ls *.bin 2>/dev/null | wc -l) != 0 ]
> + then
> + RESULTS_DIR=$KERNEL_VERSION/test-$1/$2/
Let's make local variables local.
> +
> + echo "Moving *.bin to $RESULTS_DIR"
I would remove this message, it doesn't add much value.
> + mkdir -p $RESULTS_DIR
> + mv *.bin $RESULTS_DIR
> + for f in $RESULTS_DIR/*.bin
> + do
> + ./bin2png.sh "$f"
> + done
Converting binary files to png on the target would slow down the tests. How
about performing the conversion on the host instead ?
> + fi
> +}
> +
> +run_suite() {
> + echo "Test loop $1"
How about "--- Test loop $1 ---" here for the same reason as above ?
No need to resubmit, I'll fix while applying.
> +
> + for test in vsp-unit-test*.sh; do
> + run_test $test $1;
> + done;
> +}
> +
> +for loop in `seq 1 1 $1`; do
> + run_suite $loop
> +done;
--
Regards,
Laurent Pinchart
