Hi Kieran,
Thank you for the patch.
On Friday 10 Feb 2017 13:30:05 Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
>
> Parameters can contain characters not suited to use in filenames.
>
> Add '=','(', and ')' to the filtering, and replace with '_'
>
> This reduces extra escaping, and quoting when working with the output
> filenames of failed tests and VSP_KEEP_FRAMES=1
I agree that some characters can increase the difficulty of handling file
names in scripts or on the command line by requiring escaping. I would prefer
fixing the scripts, but I'll accept this patch on the ground that the
information loss caused by replacing the =, ( and ) characters with _ will not
adversely affect our tests. If that turns out not to be true anymore in the
future I reserve the right to revert the patch and ask you to fix your scripts
:-)
> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> ---
> scripts/vsp-lib.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
> index 8f2755b57519..9e5e57b8c4ba 100755
> --- a/scripts/vsp-lib.sh
> +++ b/scripts/vsp-lib.sh
> @@ -258,6 +258,9 @@ compare_frames() {
> local params=${args// /-}
> params=${params:+-$params}
> params=${params//\//_}
> + params=${params//=/_}
> + params=${params//(/_}
> + params=${params//)/_}
> params=$in_fmt-$out_fmt-$size$params
>
> if [ x$__vsp_pixel_perfect != xtrue ] ; then
--
Regards,
Laurent Pinchart
