Hi Jacopo, On Tue, Jan 31, 2017 at 11:24 AM, jacopo mondi <jacopo@xxxxxxxxxx> wrote: > On 26/01/2017 20:54, Geert Uytterhoeven wrote: >> On Wed, Jan 25, 2017 at 7:09 PM, Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> >> wrote: >>> >>> Add pincontroller node compatible with the new Renesas RZ/A1 >>> pincontroller driver. >>> >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> >>> --- >>> arch/arm/boot/dts/r7s72100.dtsi | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/r7s72100.dtsi >>> b/arch/arm/boot/dts/r7s72100.dtsi >>> index 3dd427d..764006d 100644 >>> --- a/arch/arm/boot/dts/r7s72100.dtsi >>> +++ b/arch/arm/boot/dts/r7s72100.dtsi >>> @@ -171,6 +171,18 @@ >>> }; >>> }; >>> >>> + pinctrl: pinctrl@fcfe3000 { >>> + compatible = "renesas,rza1-pinctrl"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + #pinctrl-cells = <2>; >> >> >> Souldn't that be <3>? >> E.g. <RZ_PIN(3, 0) ALTERNATE_FUNC_6> expands to <3 0 5>, i.e. 3 numbers. >> > > From pinctrl-bindings.txt: > > #pinctrl-cells: Number of pin control cells in addition to the index within > the pin controller device instance IC. I incorrectly assumed it would be the number of cells after a pinctrl phandle, which is superfluous here as these are subnodes of the pfc node. > So here it's (2 + 1) as at least the pin index (first parameter) is > mandatory. > > We're twisting the assumption of having "index" as first, single, parameter, > as we have <bank pin mode> and the <bank, pin> pair identifies a pin. > > Hope this is ok, and we can re-use existing bindings even if our semantic is > a bit different. That's indeed a bit of twisting ;-) You can fix that by keeping the RZ_PIN() macro, and changing it to e.g. #define RZ_PIN(bank, pin) ((bank) << 16 | (pin)) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds