Re: [PATCH 3/3] sh_eth: stop using bare numbers for EESIPR values

[Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>]

On 01/23/2017 11:00 AM, Geert Uytterhoeven wrote:

> > Now  that we  have almost all EESIPR bits declared (and those that  are
> > still not are most probably reserved anyway) we can at last replace the
> > bare  numbers used for 'sh_eth_cpu_data::eesipr_value' initializers with
> > the bit names ORed together...
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> >
> > ---
> >  drivers/net/ethernet/renesas/sh_eth.c |   89 +++++++++++++++++++++++++++++-----
> >  1 file changed, 78 insertions(+), 11 deletions(-)
> >
> > Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
> > ===================================================================
> > --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
> > +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
>
> > @@ -800,7 +843,12 @@ static struct sh_eth_cpu_data sh7734_dat
> >
> >         .ecsr_value     = ECSR_ICD | ECSR_MPD,
> >         .ecsipr_value   = ECSIPR_LCHNGIP | ECSIPR_ICDIP | ECSIPR_MPDIP,
> > -       .eesipr_value   = EESIPR_RFCOFIP | EESIPR_ECIIP | 0x003f07ff,
> > +       .eesipr_value   = EESIPR_RFCOFIP | EESIPR_ECIIP |
> > +                         EESIPR_FTCIP | EESIPR_TDEIP | EESIPR_TFUFIP |
> > +                         EESIPR_FRIP | EESIPR_RDEIP | EESIPR_RFOFIP |
>
> Missing:
>
>         EESIPR_DLCIP | EESIPR_CDIP | EESIPR_TROIP |

   Hm, I thought I'd double-checked all the initializers... TY!

> > +                         EESIPR_RMAFIP | EESIPR_CEEFIP | EESIPR_CELFIP |
> > +                         EESIPR_RRFIP | EESIPR_RTLFIP | EESIPR_RTSFIP |
> > +                         EESIPR_PREIP | EESIPR_CERFIP,
> >
> >         .tx_check       = EESR_TC1 | EESR_FTC,
> >         .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
> > @@ -830,7 +878,12 @@ static struct sh_eth_cpu_data sh7763_dat
> >
> >         .ecsr_value     = ECSR_ICD | ECSR_MPD,
> >         .ecsipr_value   = ECSIPR_LCHNGIP | ECSIPR_ICDIP | ECSIPR_MPDIP,
> > -       .eesipr_value   = EESIPR_RFCOFIP | EESIPR_ECIIP | 0x003f07ff,
> > +       .eesipr_value   = EESIPR_RFCOFIP | EESIPR_ECIIP |
> > +                         EESIPR_FTCIP | EESIPR_TDEIP | EESIPR_TFUFIP |
> > +                         EESIPR_FRIP | EESIPR_RDEIP | EESIPR_RFOFIP |
>
> Likewise

   :-<

> > +                         EESIPR_RMAFIP | EESIPR_CEEFIP | EESIPR_CELFIP |
> > +                         EESIPR_RRFIP | EESIPR_RTLFIP | EESIPR_RTSFIP |
> > +                         EESIPR_PREIP | EESIPR_CERFIP,
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

   Will add, thanks again...

> Gr{oetje,eeting}s,
>
>                         Geert

MBR, Sergei