Hello Rob, On Monday, January 23, 2017, Rob Herring wrote: > > --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > > +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > > @@ -25,8 +25,32 @@ Required properties: > > "renesas,sdhi-r8a7795" - SDHI IP on R8A7795 SoC > > "renesas,sdhi-r8a7796" - SDHI IP on R8A7796 SoC > > > > +- clocks: Most controllers only have 1 clock source per channel. > However, on > > + some variations of this controller, the internal card detection > > This should be explicit as to which compatible strings have 2 clocks and > which have 1 clock. OK. I'll make a list like I did for sh_mmcif: https://patchwork.kernel.org/patch/9512091/ > > + > > +Example showing 2 clocks: > > + sdhi0: sd@e804e000 { > > mmc@... I'm confused. I see that for all SDHI controllers, it either "sd@" or "sdhci@". $ grep sdhi $(find arch/arm/boot/dts -name "*.dtsi") $ grep sdhci $(find arch/arm/boot/dts -name "*.dtsi") Regards, Chris