Hi Niklas, On Fri, Jan 20, 2017 at 11:03 PM, Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx> wrote: > Nice patch! It took me a while to understand why you didn't need to read > the register before writing to it in cpg_mssr_deassert() :-) Yeah, deassertion and assertion are asymmetrical. Note that on older (not yet supported) SH/R-Mobile parts, there are no reset clear registers, and deassertion is symmetrical. > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds