Hi Wolfram,
On Tue, Jan 17, 2017 at 9:21 AM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>> The reason is that would then keep me from having to modify the existing
>> functions sh_mobile_sdhi_clk_enable/disable.
>
> Why do you prefer this? I may be missing something but a small if-block
> per function are not expensive IMO.
>
>> Is anyone going to have an issue if I turn the card-detect clock on but never
>> turn it off???? That was the patch that I was going to test out and submit.
>
> It smells a bit hacky to me. And while hacky things are sometimes
> needed, IMO this doesn't hold true here. With just 3 more lines (an
> if-block in disable and a variable for the new clock) we can have it
> proper.
I have no idea if the SDHI driver disables the module clock when it is
idle, but shouldn't the card detect clock be running all the time when the
driver is bound to the device?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
