Hi Jacopo,
On Thu, Jan 12, 2017 at 11:51 PM, Jacopo Mondi
<jacopo+renesas@xxxxxxxxxx> wrote:
> From: Jacopo Mondi <jacopo@xxxxxxxxxx>
>
> Add IIO driver for Maxim MAX11100 single-channel ADC.
> Add DT bindings documentation.
>
> Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> Tested-by: Marek Vasut <marek.vasut@xxxxxxxxx>
> .../devicetree/bindings/iio/adc/max11100.txt | 17 ++
> drivers/iio/adc/Kconfig | 9 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/max11100.c | 187 +++++++++++++++++++++
> 4 files changed, 214 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/max11100.txt
> create mode 100644 drivers/iio/adc/max11100.c
When submitting a new driver with DT bindings, please split off the
DT binding docs in a separate patch, and CC devicetree@xxxxxxxxxxxxxxx,
Rob Herring, and Mark Rutland.
scripts/get_maintainer.pl is your friend ;-)
Reviewing DT binding docs only...
> new file mode 100644
> index 0000000..6877c11
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/max11100.txt
> @@ -0,0 +1,17 @@
> +* Maxim max11100 Analog to Digital Converter (ADC)
> +
> +Required properties:
> + - compatible: Should be "maxim,max11100"
> + - vref-supply: phandle to the regulator that provides reference voltage
As this is an SPI slave device, there should be a "reg" property.
> +
> +Optional properties:
> + - spi-max-frequency: SPI maximum frequency
> +
> +Example:
> +
> +adc0: max11100@0 {
As per ePAPR Section 2.2.2 "Generic Names Recommendation", node names
should be "somewhat generic, reflecting the function of the device and
not its precise programming model.".
The label property defines a human readable string describing a device.
Hence "max11100: adc@0" is more appropriate.
> + compatible = "maxim,max11100";
Missing "reg = <0>;" matching the unit-address above.
> + vref-supply = <&adc0_vref>;
> + spi-max-frequency = <240000>;
> +};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
