Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 12 Jan 2017 16:46:47 +0100

> What I now see is that a few lines further up there is:
> 
> 	 if (skb_put_padto(skb, ETH_ZLEN))
> 		goto drop;
> 
> 	where ETH_ZLEN is 60.
> 
> So I don't think we need to worry about skb->len being less than 60 and
> this patch can be simplified to:
> 
> 	if (len == 0)
> 		len = 4;

I'd say this might deserve a comment...



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux