Hi Kieran, Thanks for the patch! On Tue, Jan 03, 2017 at 05:05:58PM +0000, Kieran Bingham wrote: > On 03/01/17 13:36, Laurent Pinchart wrote: > > Hi Kieran, > > > > Thank you for the patch. > > > > On Tuesday 03 Jan 2017 13:12:11 Kieran Bingham wrote: > >> Drivers must not perform unbalanced calls to stop the entity pipeline, > >> however if they do they will fault in the core media code, as the > >> entity->pipe will be set as NULL. We handle this gracefully in the core > >> with a WARN for the developer. > >> > >> Replace the erroneous check on zero streaming counts, with a check on > >> NULL pipe elements instead, as this is the symptom of unbalanced > >> media_pipeline_stop calls. > >> > >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > > > This looks good to me, > > > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > I'll let Sakari review and merge the patch. > > Ahh, yes - I forgot to mention, although perhaps it will be obvious for > Sakari - but this patch is based on top of Sakari's pending media > pipeline and graph walk cleanup series :D I've applied this on top of the other patches. It's always good to mention dependencies to other patches, that's very relevant for reviewers. -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
