Hi Laurent, On 2016-12-18 21:31, Laurent Pinchart wrote: > Hi Stefan and Thierry, > > As the author and suggester of the other bus flags, could you please review > this patch ? It looks to me like an appropriate use case for the flag. One remark below: > > On Saturday 19 Nov 2016 05:28:04 Laurent Pinchart wrote: >> The flag indicates that data is mirrored on the bus. The exact meaning >> is bus-type dependent. For LVDS buses it indicates that the seven data >> bits that transmitted in a clock pulse are sent in slots 6 to 0 order. >> >> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> >> --- >> include/drm/drm_connector.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h >> index ac9d7d8e0e43..5c1dda236760 100644 >> --- a/include/drm/drm_connector.h >> +++ b/include/drm/drm_connector.h >> @@ -159,6 +159,8 @@ struct drm_display_info { >> #define DRM_BUS_FLAG_PIXDATA_POSEDGE (1<<2) >> /* drive data on neg. edge */ >> #define DRM_BUS_FLAG_PIXDATA_NEGEDGE (1<<3) >> +/* data is mirrored on the bus */ >> +#define DRM_BUS_FLAG_DATA_MIRROR (1<<4) Sounds like a bit endianness issue. I am wondering is if "mirror" is a good term. Can we name the possible orderings? How about: DRM_BUS_FLAG_DATA_MSB_TO_LSB DRM_BUS_FLAG_DATA_LSB_TO_MSB -- Stefan >> >> /** >> * @bus_flags: Additional information (like pixel signal polarity) for