On Fri, Dec 9, 2016 at 12:21 AM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > On Friday 09 Dec 2016 00:15:51 Niklas Söderlund wrote: >> This was changed for the whole driver after the original patch was >> applied (at the time of change the patch was not yet reverted), see [1]. >> I needed to update this when I resurrected the patch, maybe I could have >> been more clever and reverted the revert patch but this felt cleaner, if >> it's better to do it the other way around and revert a revert please let >> me know so I can do so in the future. > > No, this is fine. I'm a bit dubious about [1] given that it consumes more CPU > cycles without any benefit as far as I can see. Maybe I can't see far enough > though, Linus Walleij could prove me wrong :-) This was changed mainly for maintainability and code readability. Lots of subsystems have the option to carry around a data poiner and/or allocate an extra memory chunk for state containers. I am relaxed on it, if someone very much want to use container_of() because of $REASON I am not really bothered. Yours, Linus Walleij
