On 12/08/2016 03:28 PM, Sergei Shtylyov wrote:
Good to see that somebody cares still about this driver, one more task off my back. :-) On 12/07/2016 07:28 PM, Niklas Söderlund wrote: You only enable the WOL support fo the R-Car gen2 chips but never say that explicitly, neither in the subject nor here.
Some patch description wouldn't hurt here, especially with the way you implemented this support, e.g. RPM vs clk API -- that needs some explanation...
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> --- drivers/net/ethernet/renesas/sh_eth.c | 120 +++++++++++++++++++++++++++++++--- drivers/net/ethernet/renesas/sh_eth.h | 4 ++ 2 files changed, 116 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 05b0dc5..3974046 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c
[...]
diff --git a/drivers/net/ethernet/renesas/sh_eth.h b/drivers/net/ethernet/renesas/sh_eth.h index d050f37..26c6620 100644 --- a/drivers/net/ethernet/renesas/sh_eth.h +++ b/drivers/net/ethernet/renesas/sh_eth.h @@ -493,6 +493,7 @@ struct sh_eth_cpu_data { unsigned shift_rd0:1; /* shift Rx descriptor word 0 right by 16 */ unsigned rmiimode:1; /* EtherC has RMIIMODE register */ unsigned rtrate:1; /* EtherC has RTRATE register */ + unsigned magic:1; /* EtherC have PMDE in ECMR and MPDIP in ECSIPR */OK, e.g. RZ/A1 doesn't have these bits...
However, I'd prefer that the comment be reworded as such: /* EtherC has ECMR.PMDE and ECSR.MPD */ or /* EtherC has ECMR_PMDE and ECSR_MPD */ MBR, Sergei
