Hello Wolfram, On Thu, Dec 01, 2016 at 11:04:40PM +0100, Wolfram Sang wrote: > Add support for R-Car Gen3 thermal sensors. Polling only for now, > interrupts will be added incrementally. Same goes for reading fuses. > This is documented already, but no hardware available for now. > > Signed-off-by: Hien Dang <hien.dang.eb@xxxxxxxxxxx> > Signed-off-by: Thao Nguyen <thao.nguyen.yb@xxxxxxxxxxxxxxx> > Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxx> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > --- > > Changes since v3: > > * call 'init' callback a tad earlier, avoids need for locking > * converted spinlock to mutex and simplified locking (only done against > concurrent access in rcar_gen3_thermal_get_temp() now) > * use usleep_range instead of udelay > * use s64 instead of long (int didn't work) > * fixed an error path > * simplified rcar_gen3_thermal_update_temp() and its use > When I try compiling this driver (from this commit only), using multi_v7_defconfig, I get this error when set as module: ERROR: "__aeabi_ldivmod" [drivers/thermal/rcar_gen3_thermal.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed And these errors when builtin: LD init/built-in.o drivers/built-in.o: In function `rcar_gen3_thermal_get_temp': :(.text+0x461778): undefined reference to `__aeabi_ldivmod' :(.text+0x461798): undefined reference to `__aeabi_ldivmod' drivers/built-in.o: In function `rcar_gen3_thermal_probe': :(.text+0x461948): undefined reference to `__aeabi_ldivmod' :(.text+0x461998): undefined reference to `__aeabi_ldivmod' :(.text+0x4619d0): undefined reference to `__aeabi_ldivmod' drivers/built-in.o::(.text+0x4619fc): more undefined references to `__aeabi_ldivmod' follow Makefile:962: recipe for target 'vmlinux' failed make: *** [vmlinux] Error 1 So, definitely would make sense to squash patch 5 here. BUT, looking closer to it, I am getting this in the menuconfig on the flag you added: │ Symbol: 64BIT [=64BIT] │ │ Type : unknown Am I missing something? BR, Eduardo
