Hi Russell,
On Friday 02 Dec 2016 14:18:08 Russell King - ARM Linux wrote:
> On Fri, Dec 02, 2016 at 01:43:26AM +0200, Laurent Pinchart wrote:
> > From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> >
> > The current code hard codes the call of hdmi_phy_configure() to be 8bpp
> > and provides extraneous error checking to verify that this hardcoded
> > value is correct.
> >
> > Simplify the passing of the data by setting the parameter to be of the
> > enum type it represents rather than converting and then verifying the
> > value. This will allow the compiler to check the value is acceptable
> > based on the type, and remove the dead code that we currently have.
>
> I think you're expecting too much of the compiler there. There's no
> requirement for the compiler to check that an enum type is passed one
> of it's defined values.
You're right.
Given that the current driver hardcodes the resolution value to 8bpp, how
about just dropping the argument ? We can always add it back later if/when
needed.
> Try building this and see if it even produces a warning:
>
> enum foo {
> FOO_1,
> FOO_2,
> };
>
> int func(enum foo foo)
> {
> return foo;
> }
>
> int test_1(void)
> {
> return func(FOO_1);
> }
>
> int test_2(void)
> {
> return func(5);
> }
--
Regards,
Laurent Pinchart
