Hello Geert, Thank you for the review. > -----Original Message----- > From: geert.uytterhoeven@xxxxxxxxx > [mailto:geert.uytterhoeven@xxxxxxxxx] On Behalf Of Geert Uytterhoeven > Sent: 23 November 2016 08:06 > To: Chris Paterson <Chris.Paterson2@xxxxxxxxxxx> > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Michael Turquette > <mturquette@xxxxxxxxxxxx>; Stephen Boyd <sboyd@xxxxxxxxxxxxxx>; > Linux-Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>; linux-clk <linux- > clk@xxxxxxxxxxxxxxx>; Ramesh Shanmugasundaram > <ramesh.shanmugasundaram@xxxxxxxxxxxxxx> > Subject: Re: [PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock > > Hi Chris, > > On Wed, Nov 23, 2016 at 9:03 AM, Geert Uytterhoeven <geert@linux- > m68k.org> wrote: > > On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson > > <chris.paterson2@xxxxxxxxxxx> wrote: > >> Signed-off-by: Ramesh Shanmugasundaram > >> <ramesh.shanmugasundaram@xxxxxxxxxxxxxx> > >> Signed-off-by: Chris Paterson <chris.paterson2@xxxxxxxxxxx> > > BTW, as all patches in this series were Signed-off-by Ramesh first, does that > mean he's the author, and you should have added his From: line, too? Technically I authored these patches, but they are direct ports from Ramesh's r8a7795 patches [1][2][3]. [1] 11c6fb7 clk: shmobile: r8a7795: Add CAN peripheral clock [2] 7e00d631 clk: shmobile: r8a7795: Add CANFD clock [3] a080c8c clk: shmobile: r8a7795: Add CAN FD peripheral clock Apologies for not making this clear in the cover letter. Kind regards, Chris > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds