On Fri, Nov 4, 2016 at 6:53 PM, Kieran Bingham
<kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote:
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> +static void vsp1_video_wb_process_buffer(struct vsp1_video *video)
> +{
> + if (buf) {
> + video->rwpf->mem = buf->mem;
> +
> + /*
> + * Store this buffer as pending. It will commence at the next
> + * frame start interrupt
> + */
> + video->pending = buf;
> + list_del(&buf->queue);
> + } else {
> + /* Disable writeback with no buffer */
> + video->rwpf->mem = (struct vsp1_rwpf_memory) { 0 };
drivers/media/platform/vsp1/vsp1_video.c:946:30: warning: missing
braces around initializer [-Wmissing-braces]
video->rwpf->mem = (struct vsp1_rwpf_memory) { 0 };
> +static void vsp1_video_wb_stop_streaming(struct vb2_queue *vq)
> +{
> + struct vsp1_video *video = vb2_get_drv_priv(vq);
> + struct vsp1_rwpf *rwpf = video->rwpf;
> + struct vsp1_pipeline *pipe = rwpf->pipe;
> + struct vsp1_vb2_buffer *buffer;
> + unsigned long flags;
> +
> + /*
> + * Disable the completion interrupts, and clear the WPF memory to
> + * prevent writing out frames
> + */
> + spin_lock_irqsave(&video->irqlock, flags);
> + video->frame_end = NULL;
> + rwpf->mem = (struct vsp1_rwpf_memory) { 0 };
drivers/media/platform/vsp1/vsp1_video.c:1008:22: warning: missing
braces around initializer [-Wmissing-braces]
rwpf->mem = (struct vsp1_rwpf_memory) { 0 };
Either drop the "0":
mem = (struct vsp1_rwpf_memory) { };
or add an additional pair of braces:
mem = (struct vsp1_rwpf_memory) { { 0 } };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
