Hi Khiem, On Tue, May 10, 2016 at 6:42 AM, Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxxxxxx> wrote: > --- a/drivers/clk/renesas/rcar-gen3-cpg.c > +++ b/drivers/clk/renesas/rcar-gen3-cpg.c > @@ -28,6 +28,146 @@ > + val = (clk_readl(zclk->reg) & CPG_FRQCRC_ZFC_MASK) Please use readl()/writel() instead of clk_readl/()/clk_writel(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds