Hi Ulrich, On Wed, Sep 14, 2016 at 6:47 PM, Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> wrote: > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> > --- > drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 255 +++++++++++++++++++++++++++++++++++ > 1 file changed, 255 insertions(+) > > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c > index 42db745..607adf7 100644 > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c > @@ -1490,6 +1490,191 @@ static const struct sh_pfc_pin pinmux_pins[] = { > +/* - HSCIF2 ----------------------------------------------------------------- */ > +static const unsigned int hscif2_data_a_pins[] = { > + /* RX, TX */ > + RCAR_GP_PIN(6, 8), RCAR_GP_PIN(6, 9), > +}; > +static const unsigned int hscif2_data_a_mux[] = { > + HRX2_A_MARK, HTX2_A_MARK, > +}; > +static const unsigned int hscif2_clk_a_pins[] = { > + /* SCK */ > + RCAR_GP_PIN(6, 10), > +}; > +static const unsigned int hscif2_clk_a_mux[] = { > + HSCK2_A_MARK, > +}; > +static const unsigned int hscif2_ctrl_a_pins[] = { > + /* RTS, CTS */ > + RCAR_GP_PIN(6, 7), RCAR_GP_PIN(6, 6), > +}; > +static const unsigned int hscif2_ctrl_a_mux[] = { > + HRTS2_N_A_MARK, HCTS2_N_A_MARK, > +}; > + > +static const unsigned int hscif2_data_b_pins[] = { > + /* RX, TX */ > + RCAR_GP_PIN(6, 17), RCAR_GP_PIN(6, 18), > +}; > +static const unsigned int hscif2_data_b_mux[] = { > + HRX2_B_MARK, HTX2_B_MARK, > +}; > +static const unsigned int hscif2_clk_b_pins[] = { > + /* SCK */ > + RCAR_GP_PIN(6, 21), > +}; > +static const unsigned int hscif2_clk_b_mux[] = { > + HSCK1_B_MARK, > +}; > +static const unsigned int hscif2_ctrl_b_pins[] = { > + /* RTS, CTS */ > + RCAR_GP_PIN(6, 20), RCAR_GP_PIN(6, 19), > +}; > +static const unsigned int hscif2_ctrl_b_mux[] = { > + HRTS2_N_B_MARK, HCTS2_N_B_MARK, > +}; You forgot to add group C for HSCIF2, which does not exist on H3. The rest looks OK to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds