On Tue, Sep 13, 2016 at 02:48:26PM +0200, Ulf Hansson wrote: > On 13 September 2016 at 12:56, Simon Horman <horms+renesas@xxxxxxxxxxxx> wrote: > > > > Hi, > > > > this series is based on work by Ai Kyuse to add UHS-I SDR-104 support for > > sh_mobile_sdhi. It builds on work by Shinobu Uehara, Rob Taylor, William > > Towle and Ian Molton, Ben Hutchings, Wolfram Sang and others to add UHS-I > > SDR-50 support to the same driver. > > > > It is based on a merge of the next branches of the mmc tree. > > > > To aid review the following git branch is provided: > > * https:://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/sdr104-driver-v7 > > > > Overview of changes since v6: > > * Address review by Ulf > > - Detailed in per-patch changelogs > > * Move integration (arm/arm64 dt) patches to separate patchset > > > > Please see http://elinux.org/Tests:SD-SDHI-SDR104 for indicative tests > > results. > > > > > > Ai Kyuse (3): > > mmc: tmio: enhance illegal sequence handling > > mmc: tmio: Add hw reset support > > mmc: tmio: Add tuning support > > > > Simon Horman (3): > > mmc: core: Add helper to see if a host can be retuned > > mmc: tmio: document mandatory and optional callbacks > > mmc: sh_mobile_sdhi: Add tuning support > > > > drivers/mmc/host/sh_mobile_sdhi.c | 265 +++++++++++++++++++++++++++++++++++++- > > drivers/mmc/host/tmio_mmc.h | 18 ++- > > drivers/mmc/host/tmio_mmc_pio.c | 87 ++++++++++++- > > include/linux/mmc/host.h | 5 + > > 4 files changed, 367 insertions(+), 8 deletions(-) > > > > -- > > 2.7.0.rc3.207.g0ac5344 > > > > This looks good to me, although I would like to get an ack from > Wolfram before I queue this up. So, I did test this on my M3-W Salvator-X (with the fixup patch Simon sent on top of this series): + My SanDisk card always gets properly tuned; re-inserting works + My Samsung card gets properly tuned if it is the first card inserted to a slot. - The Samsung card does not get tuned when it was not the first card in a slot, i.e. it was re-inserted or the SanDisk card had been used in that slot before: [ 56.799203] mmc2: tuning execution failed: -5 [ 56.803565] mmc2: error -5 whilst initialising SD card Note that if I re-insert the SanDisk card to this slot, it will be tuned correctly. Just the Samsung card will continue to fail. Any pointers? Maybe some more re-initialization? Regards, Wolfram
Attachment:
signature.asc
Description: PGP signature
