Hi Niklas, Thank you for the patch On Tuesday 13 Sep 2016 16:03:11 Niklas Söderlund wrote: > Pins not associated with a GPIO port can still have other configuration > parameters. Add a new macro SH_PFC_PIN_NAMED_CFG which allows for named > pins to be declared with a set of configurations. The new macro is an > modification of SH_PFC_PIN_NAMED to allow for optional configuration to > be assigned. > > The flag SH_PFC_PIN_CFG_NO_GPIO is still enforced as this should only be > used to define pins not associated with a GPIO port. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/pinctrl/sh-pfc/sh_pfc.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h > b/drivers/pinctrl/sh-pfc/sh_pfc.h index 5e966c0..a6a2346 100644 > --- a/drivers/pinctrl/sh-pfc/sh_pfc.h > +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h > @@ -507,6 +507,14 @@ extern const struct sh_pfc_soc_info shx3_pinmux_info; > .configs = SH_PFC_PIN_CFG_NO_GPIO, \ > } > > +/* SH_PFC_PIN_NAMED_CFG - Expand to a sh_pfc_pin entry with the given name > */ +#define SH_PFC_PIN_NAMED_CFG(row, col, _name, cfgs) \ > + { \ > + .pin = PIN_NUMBER(row, col), \ > + .name = __stringify(PIN_##_name), \ > + .configs = SH_PFC_PIN_CFG_NO_GPIO | cfgs, \ > + } > + > /* PINMUX_DATA_ALL - Expand to a list of PORT_name_DATA, PORT_name_FN0, > * PORT_name_OUT, PORT_name_IN marks > */ -- Regards, Laurent Pinchart