On Monday 05 Sep 2016 17:57:11 Geert Uytterhoeven wrote: > On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart wrote: > >> + for (n = 0; n < 6; n++) > > > > Nitpicking, the driver uses pre-increment in for loops (++n), not post- > > increment. This used to be a best-practice rule in C++, where > > pre-increment can be faster for non-native types (see > > http://antonym.org/2008/05/stl-iterators-and-performance.html for > > instance). I'm not sure if that's still relevant, but I've taken the > > habit of using the pre-increment operator in for loops, and that's what > > the rest of this driver does. This comment applies to all other locations > > in this file. > > <surprised> > Didn't know we used C++ and operator overloading in the kernel... > </surprised> Really ? Where were you when we decided to switch to C++ ? :-) On a more serious note, as I've explained, the *style* comes from a best practice rule in C++. This obviously makes no difference whatsoever in C, nor does it in C++ for integer types, it's only a matter of consistency with the rest of the driver. -- Regards, Laurent Pinchart
